Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fast-glob usage on Windows #292

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Fix fast-glob usage on Windows #292

merged 3 commits into from
Apr 11, 2022

Conversation

jeffijoe
Copy link
Owner

Problem: fast-glob only works with /.

Solution: replace all \ with / in the glob pattern before passing to fast-glob.

Closes #291

@jeffijoe jeffijoe marked this pull request as ready for review April 11, 2022 14:25
@jeffijoe jeffijoe merged commit d99a28e into master Apr 11, 2022
@coveralls
Copy link

coveralls commented Apr 11, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 02e73de on fix/glob-windows into 1d0dd1c on master.

@jeffijoe jeffijoe deleted the fix/glob-windows branch August 26, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

container.loadModules no work on windows11
2 participants