New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add myself (pavellishin) to player list #15

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@pavellishin
Copy link
Collaborator

pavellishin commented Jan 5, 2019

No description provided.

@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 5, 2019

I'm ok with this going in, as long as you promise to submit a PR to remove yourself from players.txt if you get bored and want to stop playing.

(This is only needed until we have a fix for #19)

@pavellishin

This comment has been minimized.

Copy link
Collaborator

pavellishin commented Jan 5, 2019

I think my issue is less likely to be boredom, and more likely to be "cool, child has another fever, there go the next three days" :/

@dchudz

dchudz approved these changes Jan 5, 2019

@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 5, 2019

let's wait to sync and re-approve this until #12 has gone in

@jeffkaufman jeffkaufman referenced this pull request Jan 5, 2019

Closed

Add sligocki to players #20

jeffkaufman added a commit that referenced this pull request Jan 6, 2019

players: switch to a directory
Currently, when new players are added that makes merge conflicts, and requires
a lot of re-approvals.  An easy way to avoid this is to use a directory instead
of a file.

Also add everyone who has asked to be added:
 * Closes #11
 * Closes #12
 * Closes #15
 * Closes #20
 * Closes #22

We should probably merge #23 first, so we don't get stuck if we lose someone
(#19).

@TheJhyde TheJhyde added the Add Player label Jan 6, 2019

@pavellishin

This comment has been minimized.

Copy link
Collaborator

pavellishin commented Jan 7, 2019

Closing this to clear out the PR list, since we're moving to a folder-based system.

@pavellishin pavellishin closed this Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment