Add myself (pavellishin) to player list #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkaufman
approved these changes
Jan 5, 2019
|
I'm ok with this going in, as long as you promise to submit a PR to remove yourself from players.txt if you get bored and want to stop playing. (This is only needed until we have a fix for #19) |
|
I think my issue is less likely to be boredom, and more likely to be "cool, child has another fever, there go the next three days" :/ |
dchudz
approved these changes
Jan 5, 2019
|
let's wait to sync and re-approve this until #12 has gone in |
Closed
jeffkaufman
added a commit
that referenced
this pull request
Jan 6, 2019
Currently, when new players are added that makes merge conflicts, and requires a lot of re-approvals. An easy way to avoid this is to use a directory instead of a file. Also add everyone who has asked to be added: * Closes #11 * Closes #12 * Closes #15 * Closes #20 * Closes #22 We should probably merge #23 first, so we don't get stuck if we lose someone (#19).
|
Closing this to clear out the PR list, since we're moving to a folder-based system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.