Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-line input must be properly broken up #20

Closed
jefflunt opened this issue May 29, 2012 · 0 comments
Closed

Multi-line input must be properly broken up #20

jefflunt opened this issue May 29, 2012 · 0 comments

Comments

@jefflunt
Copy link
Owner

So, Rail's truncate helper works fine, except that I'm combining it with the simple_format helper, which inserts line breaks into the display of text.

The problem with this is that you could enter a simple note, such as

who
what
where
why
when
how

...which is six lines. The problem is, the thought box is only designed to hold five lines maximum, and so the text will overflow the div.

A smarter truncate (which truncates at either a maximum length, or maximum number of lines, whichever comes first) will be necessary to fix this.

jefflunt added a commit that referenced this issue Jun 4, 2012
…ext doesn't vertically overflow any longer. However, if the content is less than 100 characters, I still won't give you the option to go to the overlay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant