Fix empty ranges returned by Gaps iterators
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the sparse and dense maps are both converted to Vecs (items in dense map are coalesced by its new iterator) and compared. We'll get better messages out of test assertions this way, and it all feels a little bit neater. I've done this because I'm planning to use the dense map in more tests.
They were sometimes returning empty ranges still, and the implementation was unnecessarily complex. There may well have been other bugs hiding in there. Fixes #43. This also adds fuzzing of the gaps iterators to get a bit more confidence that they're actually right now, including fuzzing the size of the outer range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were sometimes returning empty ranges still, and the implementation
was unnecessarily complex. There may well have been other bugs hiding in
there.
Fixes #43.
This also adds fuzzing of the gaps iterators to get a bit more confidence
that they're actually right now, including fuzzing the size of the outer
range.