-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The deployment occasionally silently fails #64
Comments
Hi @nietaki Could you provide the repo address? So that I can have a further check. : ) |
The repo is https://github.com/nietaki/nietaki.github.io - I made it private recently, so I'll add you as a collaborator. I was looking through the build history to find a run with this problem, but I think I re-ran the builds that had this problem and there doesn't seem to be any evidence left over, sorry about that. I'll keep an eye out for when it happens again. |
having the same issue, except got the same result when I re-ran the job. Latest run can be viewed here; https://github.com/jtmullen/fsgp-2023-results/actions/runs/5021239571/jobs/9003481203 I'll try to investigate some more tomorrow. |
I see that this may be an issue external to this action: https://github.com/orgs/community/discussions/55820 Of course it would still be better that the action fail in this scenario. |
I was able to resolve this for my use case by forking the action and adding git configuration to increase the http post buffer size. An optional argument for post buffer size would be a nice improvement. |
Based on this issue: jeffreytse/jekyll-deploy-action#64 The original poster was able to fix the error by applying the git config to allow bigger payloads; this was done by forking the original github action, so that's what I'm doing here too
Having the same issue. The jekell repo is longavailable/longavailable.github.io. |
When pushing a large amount of data (initial push of a big repository, change with very big file(s)) may require a higher http.postBuffer setting on your git client (not the server). Refer: https://mirrors.edge.kernel.org/pub/software/scm/git/docs/git-config.html
Hi @nietaki, @longavailable, @jtmullen Thanks for your reporting. Now the issue should be fixed. Please update to the latest version Thanks & Regards |
For the alternative solution, you can use
|
I just tried the version using
I then reverted the change and it also failed with the same error2. I don't know what to think anymore 😢 l It's also quite strange that the script fails but the action reports success 🤔 For reference: Footnotes |
Switching to master fixed the issue for me! Thanks! |
Hi @pgpbpadilla, could you try to use action |
I've tried For reference: |
I did try to use your master branch, plus pre-build options and that failed. Please see the first link in my previous comment. |
Hi @pgpbpadilla, could u try with below command? pre_build_commands: pacman -S --noconfirm git-lfs; git config --global http.version HTTP/1.1; git config --global http.postBuffer 524288000 |
it seems to me that this discussion is about two separate issues:
above I see a discussion about the git issue. is it perhaps worth opening a second issue to discuss the fact that this action can fail silently such that the workflow can report success and you have to read the build log to see that it did not actually succeed? |
Hi @davidalpert @nietaki, @longavailable, @jtmullen Now the latest version has supported to deploy site via the SSH protocol for better stability comparing with HTTP protocol, here I suggest you to switch to the SSH protocol as saying. : ) Thanks & Regards |
Hi @jeffreytse I tested the SSH approach and met an error of Any suggestion?
|
@longavailable Could you try one more time? And before you try, you need to create a new secret named |
Great job @jeffreytse . The latest commit works like a charm 👏 |
It's happened a couple of times for me already: the
jeffreytse/jekyll-deploy-action@v0.4.0
action runs and it gets marked as successful, but doesn't push the built site to the deployment branch.Looking at the job logs I see the following:
It doesn't happen consistently, but only every once in a while, but makes me unable to trust my CI.
I'm not sure what the error...
...refers to specifically, but regardless, I don't think it should be failing silently.
My workflow is pretty standard, with barely anything modified from the defaults:
Let me know if there are any other details I should provide
The text was updated successfully, but these errors were encountered: