Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes to imports and names. #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cs224
Copy link

@cs224 cs224 commented May 30, 2018

I have tried using sparseMF in python 3, but ran into many problems. I am not sure if this is an issue between python 2 vs. python 3 (I only tried python 3).

  1. Many import statements were missing the required "." in front of the name
  2. The name SoftImputeALS does not exist, but only SparseSoftImputeALS
  3. The code is using xrange, which is deprecated in python3. Some other python3 issues with len on zip (see below)
  4. The tests are not running (did not manage to fix them)
  5. The documentation is not correct. There is no model.fit(X) method, but only a complete() method (at least looking at the test cases this seems to be the intended use).

It would be really helpful if you could make sure that the package is working on python 3 together with the test cases and an up-to-date minimal documentation on how to use it.

Thanks a lot!
Christian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant