Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jasmine client options #530

Closed
wants to merge 3 commits into from
Closed

Jasmine client options #530

wants to merge 3 commits into from

Conversation

tilsammans
Copy link

Continues #519

Thanks to everyone involved!

@tilsammans tilsammans mentioned this pull request Nov 14, 2017
Closed
@jsilvestri
Copy link

jsilvestri commented Jan 18, 2018 •
edited
Loading

@zzak, @tilsammans options[:client_driver_opts].symbolize_keys works as well and might address the syntax concerns here: jsilvestri@7ec4b6d

I have tested it with selenium-webdriver 3.8.0.

@zzak
Copy link
Contributor

zzak commented Jan 19, 2018

@jsilvestri I believe Hash#symbolize_keys is only available in ActiveSupport, but not sure that is a concern here.

@jsilvestri
Copy link

jsilvestri commented Jan 19, 2018 •
edited
Loading

@zzak correct. Agreed it may not be ideal to depend on ActiveSupport.

@andoneve andoneve mentioned this pull request Jan 26, 2018
Merged
@bmulholland bmulholland mentioned this pull request Mar 5, 2018
Merged
transoceanic2000 added a commit to transoceanic2000/teaspoon that referenced this pull request Mar 7, 2018
@transoceanic2000
Try the dup approach from jejacks0n#530
bbcccd4
ericgriffis added a commit to NYULibraries/eshelf that referenced this pull request Jun 27, 2018
@ericgriffis
Configure teaspoon on chrome headless; not working
81ccd1c 
References:
- jejacks0n/teaspoon#519
- jejacks0n/teaspoon#530
- codevise/pageflow#952
@jejacks0n jejacks0n force-pushed the master branch 3 times, most recently from 1d95ed2 to d6352cb Compare April 29, 2019 23:34
@mathieujobin
Copy link
Collaborator

looks like #537 properly fix this issue, please reopen if you disagree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzak zzak zzak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tilsammans @jsilvestri @zzak @mathieujobin