Fix the build #552
Merged
Fix the build #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 7, 2018
| gem "sprockets", ">= 4.0.0.beta2" | ||
|
|
||
| gemspec name: "teaspoon" | ||
|
|
||
| group :development, :test do | ||
| gemspec name: "teaspoon-devkit" | ||
|
|
||
| gem "puma" |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -1,13 +1,15 @@ | |||
| source "https://rubygems.org" | |||
|
|
|||
| gem "rails", "5.0.0.1" | |||
| gem "rails", "5.0.1" | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
houndci-bot
reviewed
Dec 7, 2018
jejacks0n
pushed a commit
that referenced
this pull request
May 9, 2019
* Quick check to see if this fixes CI * Trying something else... * Another idea * Clean the cache...? * Again... * Progress...? * Not very bright, am I? * Now you are taking the piss * Call me paranoid but, could those trailing spaces be to blame? * Random failure? Trying again * Might be ok to bring the cache back now * Is this the beforeEach that is causing trouble? * Behaviour must have changed lately... * Complaining that geckodriver already exists? Bust the cache again * Argh, I commited geckodriver by accident * Festival del humor * Of course QUnit had to join the party * Green! We can bring back the cache now * Shouldn't have commited this either * Hound!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this fixes the build! Some notes:
teaspoon-jasmine/spec/javascripts/jasmine2/fixture_spec.coffee. Something must have changed in the behaviour offixture.loadthat Jasmine 2 doesn't agree with it.toEqual) the html contents is the correct expectation (from what I can tell), as content is appended to the fixture, and therefore we can't just expect the very same object to be infixture.elandfixtures[0](and compared withtoBe).Now I hope we can start merging PRs, particularly #537 which is the one that triggered my effort here :-)