Rewrite token in Ruby #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
reviewed
Jun 19, 2018
github/token
Outdated
| echo $TOKEN | ||
| jwt = File.expand_path("jwt", __dir__) | ||
|
|
||
| uri = URI("https://api.github.com/installations/#{ENV["INSTALLATION"]}/access_tokens") |
There was a problem hiding this comment.
Perhaps use ENV.fetch("INSTALLATION") since this is required?
github/token
Outdated
|
|
||
| uri = URI("https://api.github.com/installations/#{ENV["INSTALLATION"]}/access_tokens") | ||
| req = Net::HTTP::Post.new(uri) | ||
| req["Authorization"] = "Bearer #{`#{jwt}`}" |
There was a problem hiding this comment.
Perhaps execute the jwt script elsewhere so we can check if it fails? Or write it in Ruby so we can use it as a library here?
|
|
||
| http = Net::HTTP.new(uri.hostname, uri.port) | ||
| http.use_ssl = (uri.scheme == "https") | ||
| res = http.request(req) |
There was a problem hiding this comment.
I would highly recommend using octokit's built-in method for this if you're going to be using Ruby.
pathawks
force-pushed
the
ruby-token
branch
2 times, most recently
from
ef4f9e7
to
aaa82ab
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Ruby version is much less compact than the cURL script, but hopefully it is easier for Ruby devs to understand/debug.
/cc: #3