Hasher performance #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 2, 2015 20:46
| end | ||
|
|
||
| # Return a word hash without extra punctuation or short symbols, just stemmed words | ||
| def clean_word_hash(str, language = 'en') | ||
| word_hash_for_words str.gsub(/[^\w\s]/,"").split, language | ||
| word_hash_for_words str.gsub(/[^\p{WORD}\s]/,'').downcase.split, language | ||
| end |
There was a problem hiding this comment.
Why downcase here? Seems like it could have some really problematic side effects.
There was a problem hiding this comment.
What side effects? Its not a downcase or gsub in place, it makes a new object which is split, then passed to word_hash_for_words then downcased. All I do is downcase the entire thing at once instead of word*N times.
|
Woot! Looks good on mobile. Didn't know String#scan worked like that. |
|
String#scan isn't always faster though .. notice I only changed one of the splits to scan .. benchmarks showed the gsub/split method faster there. |
|
@parkr This looks great! |
Ch4s3
added a commit
that referenced
this pull request
Sep 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of simple performance improvements for the Hasher process. Picking a random wikipedia page and hashing it 200 times, I get the following improvements before/after (excluding the Set regression, it was a set before my last PR). Additionally, it fixes broken regex splitting for non-ascii characters and removes the unused punctuation filter.