Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopword encoding #83

Merged
merged 2 commits into from
Dec 30, 2016
Merged

Stopword encoding #83

merged 2 commits into from
Dec 30, 2016

Conversation

ibnesayeed
Copy link
Contributor

Forching UTF-8 encoding when reading stopwords, fixes #82

@ibnesayeed
Copy link
Contributor Author

I don't know why misspelling correction commit is showing up here, although it was merged earlier. Despite, it should not affect anything and can be safely merged again.

@Ch4s3
Copy link
Member

Ch4s3 commented Dec 28, 2016

Does force_encoding() preserve the contents of say, ASCII strings? This looks correct, but I always mix up encode and force_encoding.

@ibnesayeed
Copy link
Contributor Author

@Ch4s3
Copy link
Member

Ch4s3 commented Dec 30, 2016

@ibnesayeed excellent, that's what I was looking for!

@Ch4s3 Ch4s3 merged commit 03a363a into jekyll:master Dec 30, 2016
@ibnesayeed ibnesayeed deleted the stopword-encoding branch December 30, 2016 18:34
Ch4s3 added a commit that referenced this pull request Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgumentError: invalid byte sequence in US-ASCII
2 participants