Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect source passed from the API #85

Merged
merged 2 commits into from
Jan 9, 2017
Merged

Respect source passed from the API #85

merged 2 commits into from
Jan 9, 2017

Conversation

benbalter
Copy link
Contributor

The Pages API now exposes source branch and path metadata. We should use that to build the proper zip and tar URLs so we respect the source selector.

@benbalter benbalter self-assigned this Jan 2, 2017
parkr
parkr approved these changes Jan 5, 2017
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR. ❤️ Do you need me to do the release?

@benbalter
Copy link
Contributor Author

If you don't mind?

This was referenced Jan 6, 2017
Closed
Closed
@parkr
Copy link
Member

parkr commented Jan 9, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 395bf7e into master Jan 9, 2017
@jekyllbot jekyllbot deleted the respect-source branch January 9, 2017 05:36
jekyllbot added a commit that referenced this pull request Jan 9, 2017
@jekyllbot
Update history to reflect merge of #85 [ci skip]
1bf9fa3
@jekyll jekyll locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parkr parkr parkr approved these changes

Assignees

@benbalter benbalter

Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbalter @parkr @jekyllbot