Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better author support #31

Merged
merged 1 commit into from
May 22, 2015
Merged

Better author support #31

merged 1 commit into from
May 22, 2015

Conversation

pathawks
Copy link
Member

Fixes #28

@benbalter
Copy link
Contributor

Ahh nice. Checked the docs, and name is required, so there is either site.author.name, or it's not a valid object.

One thought, how do we want to handle if no author is specified, as either a string or an object? Right now, we output an empty node.

Last, would you mind updating the docs with this behavior? Awesome stuff.

@pathawks
Copy link
Member Author

Ahh nice. Checked the docs, and name is required, so there is either site.author.name, or it's not a valid object.

One thought, how do we want to handle if no author is specified, as either a string or an object? Right now, we output an empty node.

So if no author information is provided, we don't output an <author> tag, and that's ok.

If some author information is provided without a name (like URL or email), creating an <author> tag without a name is invalid.

My first thought is that this is a problem best solved with documentation. We could just make it clear that, if your site/post has an author, you must provide the author's name.

@benbalter
Copy link
Contributor

So if no author information is provided, we don't output an tag, and that's ok.

Missed the containing {% if site.author %}. 👍

@pathawks
Copy link
Member Author

I'm bad at documentation (which is to say, I suppose, that I am a lazy programmer).

Can somebody take a look and make some suggestions?

@pathawks
Copy link
Member Author

For the feed author, if nothing is provided, should we try to fallback to site.github.owner, similar to what is done for site.url?

benbalter added a commit that referenced this pull request May 22, 2015
@benbalter benbalter merged commit f8dd1b0 into jekyll:master May 22, 2015
@pathawks pathawks deleted the author-object branch May 22, 2015 20:11
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better author support
3 participants