Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit feed to 10 posts #41

Merged
merged 1 commit into from
May 21, 2015
Merged

Limit feed to 10 posts #41

merged 1 commit into from
May 21, 2015

Conversation

benbalter
Copy link
Contributor

An attempt to fix #40, or at least start the conversation, by limiting feeds to 10 posts.

Fixes #40.

@benbalter benbalter self-assigned this May 20, 2015
@parkr
Copy link
Member

parkr commented May 21, 2015

someone is going to want to make this configurable... but 10 seems reasonable to me. my feed reader will be able to hold onto old entries anyway so the latest 10 should suffice

@benbalter
Copy link
Contributor Author

A lot of @pathawks's arguments over in #40 were persuasive to me, but think it's easier to add an option than to remove one. If our experience parallels WordPress's, and 99% of users are fine with a hard limit of 10 posts, I think that's more than enough of a core user case for me to say lets leave it out.

That said, if someone submits a pull request to make in an option with a reason other than "it should be an option", I don't know that we need to be dogmatic here.

Thanks for the 💭 @parkr. Going to give this a spin in the wild, and see what type of feedback we get from users, one way or the other.

benbalter added a commit that referenced this pull request May 21, 2015
Limit feed to 10 posts
@benbalter benbalter merged commit 803a798 into master May 21, 2015
@benbalter benbalter deleted the limit branch May 21, 2015 20:46
@pathawks
Copy link
Member

it's easier to add an option than to remove one.

👍

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit RSS feed entries
4 participants