Add Rubocop #81
Merged
Add Rubocop #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pathawks Can you rebase? |
|
|
|
How does this look? |
|
LGTM. I'd also be fine dropping support for Jekyll < 3. |
|
Do I have the power? @jekyllbot: merge +dev edit: Guess not 😭 😜 |
pathawks
added a commit
that referenced
this pull request
Mar 2, 2016
Hehe, @pathawks I haven't added it to more than jekyll/jekyll yet! I need to do a better check for and enable for all repos so anyone with push access to the repo can use jekyllbot. 🔜 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until after Jekyll 3.1.0 is released, as this depends on Jekyll's
.rubocop.ymlwhich was not added until after 3.0.2.This will allow us to easily make sure we are following the same coding conventions as Jekyll. I have also updated
lib/jekyll-feed.rbto follow those same conventions.