New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing custom slug code #39

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants
@georgeanderson
Contributor

georgeanderson commented Jul 8, 2013

The custom slug code is error prone and can create wrong entries like:

2011-12-03-ruby-on-rails---easy-setup-on-ubuntu.md

Where the correct is:

2011-12-03-ruby-on-rails-easy-setup-on-ubuntu.md

It also avoids huge photo captions to be used as the file name like in my case below:

2013-07-04-george-turned-2-today-thats-an-automatic-post-from-tumblr-i-will-also-use-to-inform-the-belowim-on-my-way-out-tumblr-going-into-jekyll-direction-migration-is-in-progress-and-it-should-be-completed-soon.md

With my change the above becomes:

2013-07-04-george-turned-2-today-thats-an-automatic-post.md

@parkr: Sorry I was not able to isolate my commits again. I did something wrong with my feature branch and hope to get it right in the next time.

Thanks,
George.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 8, 2013

Member

LGTM, I'll cherry-pick your commit again :)

Member

parkr commented Jul 8, 2013

LGTM, I'll cherry-pick your commit again :)

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 8, 2013

Member

Actually maybe we should fall back to the old method if there is no post["slug"]?

Member

parkr commented Jul 8, 2013

Actually maybe we should fall back to the old method if there is no post["slug"]?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 8, 2013

Member

@georgeanderson What do you think about #40?

Member

parkr commented Jul 8, 2013

@georgeanderson What do you think about #40?

@parkr parkr closed this Jul 8, 2013

parkr added a commit that referenced this pull request Jul 8, 2013

@georgeanderson

This comment has been minimized.

Show comment
Hide comment
@georgeanderson

georgeanderson Jul 9, 2013

Contributor

@parkr Sounds good.

Contributor

georgeanderson commented Jul 9, 2013

@parkr Sounds good.

@georgeanderson georgeanderson deleted the georgeanderson:tumblr_slug branch Jul 9, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.