-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when url is missing backslash, correct redirect is not generated #10
Comments
👍 to making it handle both. 😃 |
I updated the README but it only shows one use-case. Mind writing what you think should be there and submitting a PR? |
Sure. So you just want me to submit edits for the current behavior then? Or have you also updated the plugin to work for both use-cases, so I should account for both in my edits? |
K, I just submitted a PR with my edits. If I misunderstood - apologies - just let me know. |
Is it possible to make redirects without the trailing slash work? It seems like you don't need it in the example. But when I go to a redirect url, it doesn't redirect but instead gives a file to download. |
@taigeair Sounds like a MIME types issue with the server you're using. Can you tell me a bit about the environment serving your Jekyll site? |
I'm using github pages. This is the the link I'm talking about http://www.taigeair.com/aboutz |
Write support@github.com! |
okay thanks. |
I noticed that when specifying the URL to redirect from, the trailing backslash must be included or else jekyll-redirect-from fails to produce the correct redirect.
For example...
...works as expected, producing the correct subdirectory with an index.html. However...
Does not produce
/some-url-to-redirect-from/index.html
but instead productes/some-url-to-redirect-from
where it is a file with that name, instead of a directory with an index file.Personally, I'm okay with that behavior, but think it should at least be specified in the README. However, if it's not too much work, or if you don't think it's problematic from an architecture standpoint, I'd say it might be nice to make both work as expected (i.e. any url created without a file extension should convert to a corresponding directory path with an index.html inside).
The text was updated successfully, but these errors were encountered: