Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows generation of redirects.json to be disabled #207

Merged
merged 12 commits into from
Jan 26, 2020
Merged

Allows generation of redirects.json to be disabled #207

merged 12 commits into from
Jan 26, 2020

Conversation

dmalan
Copy link
Contributor

@dmalan dmalan commented Jul 22, 2019

Per #189, it's not always desirable to generate redirects.json, particularly since it might leak information about routes that exist but that aren't actually (intended to be) linked publicly.

This PR proposes to add support for

redirect_from:
  json: false

modeled after https://github.com/benbalter/jekyll-optional-front-matter#configuration.

Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this PR.
But it needs some changes.

lib/jekyll-redirect-from/generator.rb Outdated Show resolved Hide resolved
lib/jekyll-redirect-from/generator.rb Outdated Show resolved Hide resolved
lib/jekyll-redirect-from/generator.rb Outdated Show resolved Hide resolved
lib/jekyll-redirect-from/version.rb Outdated Show resolved Hide resolved
spec/jekyll_redirect_from/generator_spec.rb Outdated Show resolved Hide resolved
@dmalan
Copy link
Contributor Author

dmalan commented Jul 22, 2019

Changes made!

@ashmaroli ashmaroli requested a review from a team July 23, 2019 09:50
@dmalan
Copy link
Contributor Author

dmalan commented Jul 23, 2019

Thanks!

README.md Show resolved Hide resolved
@DirtyF
Copy link
Member

DirtyF commented Jan 26, 2020

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit b708d48 into jekyll:master Jan 26, 2020
jekyllbot added a commit that referenced this pull request Jan 26, 2020
@jekyll jekyll locked and limited conversation to collaborators Jan 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants