-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CoffeeScript conversion support #1991
Conversation
}); | ||
|
||
}).call(this); | ||
JS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not move this into an external file as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only place I can think to put this is test/source/js/result.js
or something, and it didn't seem to make a lot of sense:
I didn't want the check to be eff'd up if Jekyll freaks out, i.e. I wanted to isolate my check from all the other tests in the test suite and from all erroneous Jekyll-related behaviours.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😃 Thanks for asking though. I often do crazy things that make sense in my head, but don't make sense to anyone else.
Can't wait for this to drop. This and #1932 are going to seriously level up Jekyll. |
@benbalter Just needs @mattr-'s 👀 :) |
Dropped the 💣 on y'all. 💥 |
It's all good – thanks @mattr-!! ✨ |
But will it be supported on Github pages? AFAIK github doesn't allow plugins. |
@vinitkumar It supports built-in plugins, like this one! |
Yeah. I confused it with the other custom plugins. That's a really great addition. Thanks! 👍 |
@parkr not sure if it's the right place to ask this, but is native |
HAML will never be available due to allowing arbitrary code execution. On Fri, Jan 31, 2014 at 3:14 AM, Pirogov Evgenij notifications@github.com
|
@mattr- gotcha. Thanks for clarifying this! |
Along with Sass (#1932) support, our vision for Jekyll 2.0 includes support for CoffeeScript out-of-the-box.
I've written a Jekyll plugin called
jekyll-coffeescript
which handles all the logic and contains the converter. This PR just integrates this plugin into Jekyll core.