Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CoffeeScript conversion support #1991

Merged
merged 1 commit into from
Jan 31, 2014
Merged

Add CoffeeScript conversion support #1991

merged 1 commit into from
Jan 31, 2014

Conversation

parkr
Copy link
Member

@parkr parkr commented Jan 26, 2014

Along with Sass (#1932) support, our vision for Jekyll 2.0 includes support for CoffeeScript out-of-the-box.

I've written a Jekyll plugin called jekyll-coffeescript which handles all the logic and contains the converter. This PR just integrates this plugin into Jekyll core.

});

}).call(this);
JS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not move this into an external file as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only place I can think to put this is test/source/js/result.js or something, and it didn't seem to make a lot of sense:

I didn't want the check to be eff'd up if Jekyll freaks out, i.e. I wanted to isolate my check from all the other tests in the test suite and from all erroneous Jekyll-related behaviours.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃 Thanks for asking though. I often do crazy things that make sense in my head, but don't make sense to anyone else.

@benbalter
Copy link
Contributor

Can't wait for this to drop. This and #1932 are going to seriously level up Jekyll.

@parkr
Copy link
Member Author

parkr commented Jan 30, 2014

@benbalter Just needs @mattr-'s 👀 :)

mattr- added a commit that referenced this pull request Jan 31, 2014
@mattr- mattr- merged commit 2b97346 into master Jan 31, 2014
mattr- added a commit that referenced this pull request Jan 31, 2014
@mattr- mattr- deleted the coffeescript branch January 31, 2014 02:39
@mattr-
Copy link
Member

mattr- commented Jan 31, 2014

Dropped the 💣 on y'all. 💥

@parkr
Copy link
Member Author

parkr commented Jan 31, 2014

It's all good – thanks @mattr-!! ✨

@vinitkumar
Copy link

But will it be supported on Github pages? AFAIK github doesn't allow plugins.

@parkr
Copy link
Member Author

parkr commented Jan 31, 2014

@vinitkumar It supports built-in plugins, like this one!

@vinitkumar
Copy link

Yeah. I confused it with the other custom plugins. That's a really great addition. Thanks! 👍

@gmile
Copy link
Contributor

gmile commented Jan 31, 2014

@parkr not sure if it's the right place to ask this, but is native haml support on the radar (even if it's a distant future)?

@mattr-
Copy link
Member

mattr- commented Jan 31, 2014

HAML will never be available due to allowing arbitrary code execution.

On Fri, Jan 31, 2014 at 3:14 AM, Pirogov Evgenij notifications@github.com
wrote:

@parkr not sure if it's the right place to ask this, but is haml on the radar (even if it's a distant future)?

Reply to this email directly or view it on GitHub:
#1991 (comment)

@gmile
Copy link
Contributor

gmile commented Jan 31, 2014

@mattr- gotcha. Thanks for clarifying this!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants