Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner removes directory if it only contain subdirectories #2204

Closed
sjoerdmulder opened this issue Apr 3, 2014 · 0 comments
Closed

Cleaner removes directory if it only contain subdirectories #2204

sjoerdmulder opened this issue Apr 3, 2014 · 0 comments
Milestone

Comments

@sjoerdmulder
Copy link

Hit a problem when working with a directory with subdirectory containing large video files, using jekyll serve -w takes around 20 seconds+ to regenerate the site.

It seems that the cleaner.rb is marking folders for deletion when they contain no other files, it uses @site.each_site_file to find the files and takes the directories only from those files to mark them as being active. So in a structure like:

my-awesome-site
  - video
      - chapter1
      - chapter2

Where the files are only in video/chapter and video/chapter2 it marks the video directory for deletion, causing the whole video folder to be copied again.

When this is fixed probally #1297 is also resolved.

Workaround for now is to have an empty index.html file in the video folder

@parkr parkr added the Bug label Apr 3, 2014
@parkr parkr added this to the 2.0 milestone Apr 3, 2014
@parkr parkr modified the milestones: 2.1, 2.0 May 5, 2014
@parkr parkr closed this as completed in 04baeef May 30, 2014
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants