Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if relative URL contains a colon #5069

Merged
merged 1 commit into from
Jul 13, 2016
Merged

check if relative URL contains a colon #5069

merged 1 commit into from
Jul 13, 2016

Conversation

Crunch09
Copy link
Member

@Crunch09 Crunch09 commented Jul 8, 2016

fixes #2834

screen shot 2016-07-08 at 20 35 47

@parkr
Copy link
Member

parkr commented Jul 9, 2016

Yes! Perfect! This LGTM. @jekyll/core, what say you?

@parkr
Copy link
Member

parkr commented Jul 11, 2016

@envygeeks do you want to take a look at this, or?

@envygeeks
Copy link
Contributor

LGTM! :shipit:

@parkr
Copy link
Member

parkr commented Jul 13, 2016

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 1f36673 into jekyll:master Jul 13, 2016
jekyllbot added a commit that referenced this pull request Jul 13, 2016
@jekyllbot
Update history to reflect merge of #5069 [ci skip]
a29498e
stevecheckoway pushed a commit to stevecheckoway/jekyll that referenced this pull request Jul 24, 2016
@jekyllbot @stevecheckoway
Update history to reflect merge of jekyll#5069 [ci skip]
5c09cf9
@markstos markstos mentioned this pull request Aug 19, 2016
Closed
12 tasks
@akoeplinger akoeplinger mentioned this pull request Aug 23, 2016
Closed
@akoeplinger
Copy link
Contributor

This breaks using URLs with colons in the jekyll-redirect-from plugin: jekyll/jekyll-redirect-from#119

This was referenced Aug 24, 2016
Closed
Closed
@icai
Copy link

icai commented Sep 9, 2016 •
edited
Loading

I don't think this is a good idea which check including colons(:) or not.
should use blacklist(year, month...) with colons to check URL, but not if sanitized_url.include?(":")

#5261
#2834

@diced-dev diced-dev mentioned this pull request Dec 5, 2016
Closed
@pathawks pathawks mentioned this pull request Feb 17, 2017
Merged
@Crunch09 Crunch09 deleted the issue-2834 branch March 2, 2017 23:39
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
fix frozen-due-to-age ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL should validate output
6 participants
@Crunch09 @parkr @envygeeks @akoeplinger @icai @jekyllbot