New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail loudly on MaRuKu errors (exit code other than 0) #1190

Merged
merged 1 commit into from Jun 7, 2013

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Jun 6, 2013

Catch and print errors when MaRuKu freaks out, and exit with an error code other than 0.

Fixes (kind of) #673.

@gcapizzi

This comment has been minimized.

Show comment
Hide comment
@gcapizzi

gcapizzi Jun 7, 2013

Contributor

👍

Contributor

gcapizzi commented Jun 7, 2013

👍

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 7, 2013

Member

Whoops, forgot to mention @mattr- ❤️

Member

parkr commented Jun 7, 2013

Whoops, forgot to mention @mattr- ❤️

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Jun 7, 2013

Member

I ❤️ this.

Member

mattr- commented Jun 7, 2013

I ❤️ this.

parkr added a commit that referenced this pull request Jun 7, 2013

Merge pull request #1190 from mojombo/maruku-errors
Fail loudly on MaRuKu errors (exit code other than 0).

@parkr parkr merged commit ae4da46 into master Jun 7, 2013

1 check passed

default The Travis CI build passed
Details

@parkr parkr deleted the maruku-errors branch Jun 7, 2013

parkr added a commit that referenced this pull request Jun 7, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.