New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diff syntax-highlighting #6388

Merged
merged 1 commit into from Sep 27, 2017

Conversation

Projects
None yet
4 participants
@ashmaroli
Member

ashmaroli commented Sep 27, 2017

Since this is subjective, its going to take some inputs from multiple perspective..

Current:
image

PR Initial Commit:

diff-syntax

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli
Member

ashmaroli commented Sep 27, 2017

@DirtyF

DirtyF approved these changes Sep 27, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Sep 27, 2017

Member

@jekyllbot: merge +docs

Member

DirtyF commented Sep 27, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 7d36527 into jekyll:master Sep 27, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@ashmaroli ashmaroli deleted the ashmaroli:docs-diff-style branch Sep 27, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Sep 27, 2017

Member

We should have kept the bold here but it's already more readable, that's what matters the most. Thanks.

Member

DirtyF commented Sep 27, 2017

We should have kept the bold here but it's already more readable, that's what matters the most. Thanks.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 27, 2017

Member

Bold + text-shadow seemed a li'l too much to me..

Member

ashmaroli commented Sep 27, 2017

Bold + text-shadow seemed a li'l too much to me..

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 27, 2017

Member

@DirtyF see the extra borders around the code blocks in the pics above..? I'm guessing it has something to do with the change in Rouge versions.. (GitHub Pages is still on the older version..)
Is that worth addressing..?

Member

ashmaroli commented Sep 27, 2017

@DirtyF see the extra borders around the code blocks in the pics above..? I'm guessing it has something to do with the change in Rouge versions.. (GitHub Pages is still on the older version..)
Is that worth addressing..?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF
Member

DirtyF commented Sep 27, 2017

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 27, 2017

Member

handled in #6389 ...

Member

ashmaroli commented Sep 27, 2017

handled in #6389 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment