New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: upgrade to toml 0.2.0 #6541

Merged
merged 1 commit into from Nov 11, 2017

Conversation

Projects
None yet
5 participants
@jekyllbot
Contributor

jekyllbot commented Nov 11, 2017

Fix #6540

Dependencies: upgrade to toml 0.2.0

@DirtyF DirtyF added the dependency label Nov 11, 2017

@DirtyF DirtyF requested a review from jekyll/stability Nov 11, 2017

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Nov 11, 2017

Member

0.2.0 or 0.4.0? 😄

Member

oe commented Nov 11, 2017

0.2.0 or 0.4.0? 😄

@DirtyF DirtyF changed the title from Dependencies: upgrade to toml 0.2.0 to Dependencies: upgrade to toml 0.4.0 Nov 11, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 11, 2017

Member

@pup Jekyllbot opened an issue for 0.2.0 but I noticed afterwards that latest version was 0.4.0 😄

Member

DirtyF commented Nov 11, 2017

@pup Jekyllbot opened an issue for 0.2.0 but I noticed afterwards that latest version was 0.4.0 😄

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF
Member

DirtyF commented Nov 11, 2017

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Nov 11, 2017

Member

yeah, it seems to be a pre-release:

image

Member

oe commented Nov 11, 2017

yeah, it seems to be a pre-release:

image

@DirtyF DirtyF changed the title from Dependencies: upgrade to toml 0.4.0 to Dependencies: upgrade to toml 0.2.0 Nov 11, 2017

@oe

oe approved these changes Nov 11, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 11, 2017

Member

@jekyllbot: merge +dev

Member

DirtyF commented Nov 11, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 8605f11 into master Nov 11, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pull/upgrade-toml branch Nov 11, 2017

@robmuh

This comment has been minimized.

Show comment
Hide comment
@robmuh

robmuh Nov 30, 2017

Contributor

Sorry if I missed it in the docs but is this thread related to TOML support in Frontmatter? If so WAHOOO, uhuem, and I would love to update the docs. If I had my way I would make TOML supported in everything (after all it is a Tom invention, like Jekyll itself, and ironically is supported in Hugo and no Jekyll, right?)

Contributor

robmuh commented Nov 30, 2017

Sorry if I missed it in the docs but is this thread related to TOML support in Frontmatter? If so WAHOOO, uhuem, and I would love to update the docs. If I had my way I would make TOML supported in everything (after all it is a Tom invention, like Jekyll itself, and ironically is supported in Hugo and no Jekyll, right?)

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 30, 2017

Member

Sorry if I missed it in the docs but is this thread related to TOML support in Frontmatter? If so WAHOOO, uhuem, and I would love to update the docs. If I had my way I would make TOML supported in everything (after all it is a Tom invention, like Jekyll itself, and ironically is supported in Hugo and no Jekyll, right?)

Hey @robmuh! TOML is only supported for your configuration file, e.g. _config.toml. TOML has so-so support in Ruby (this gem, really, and I don't believe it's currently maintained), whereas it has excellent support in Go (the language Hugo is written in). That explains the difference in support. In an effort to not confuse folks, I'd be a proponent of just using 1 configuration spec here, and YAML is much better supported in Ruby.

Member

parkr commented Nov 30, 2017

Sorry if I missed it in the docs but is this thread related to TOML support in Frontmatter? If so WAHOOO, uhuem, and I would love to update the docs. If I had my way I would make TOML supported in everything (after all it is a Tom invention, like Jekyll itself, and ironically is supported in Hugo and no Jekyll, right?)

Hey @robmuh! TOML is only supported for your configuration file, e.g. _config.toml. TOML has so-so support in Ruby (this gem, really, and I don't believe it's currently maintained), whereas it has excellent support in Go (the language Hugo is written in). That explains the difference in support. In an effort to not confuse folks, I'd be a proponent of just using 1 configuration spec here, and YAML is much better supported in Ruby.

@robmuh

This comment has been minimized.

Show comment
Hide comment
@robmuh

robmuh Nov 30, 2017

Contributor

Have to say I completely agree with your conclusion. Just wanted to be sure I didn't miss something. I must confess after reading about this Hugo embedded in AWS Lambda approach, which I am not sure is possible with Jekyll, that the scale tipped toward Hugo for me. Thanks for the info.

Contributor

robmuh commented Nov 30, 2017

Have to say I completely agree with your conclusion. Just wanted to be sure I didn't miss something. I must confess after reading about this Hugo embedded in AWS Lambda approach, which I am not sure is possible with Jekyll, that the scale tipped toward Hugo for me. Thanks for the info.

jashank added a commit to jashank/jekyll that referenced this pull request Dec 27, 2017

Switch to an actively-maintained TOML parser.
We have an ancient version of the `toml` gem which appears to have
been abandoned for years and isn't compliant with TOML 0.4.0, the
current state of the art.

The `tomlrb` and `toml-rb` gems are both (more) actively maintained
and kept up-to-date; switching to either gives us TOML 0.4.0 support.
This patch switches us to `tomlrb`.

(See also: jekyll#6540 jekyll#6541)

jashank added a commit to jashank/jekyll that referenced this pull request Dec 27, 2017

Switch to an actively-maintained TOML parser.
We have an ancient version of the `toml` gem which appears to have
been abandoned for years and isn't compliant with TOML 0.4.0, the
current state of the art.

The `tomlrb` and `toml-rb` gems are both (more) actively maintained
and kept up-to-date; switching to either gives us TOML 0.4.0 support.
This patch switches us to `tomlrb`.

(See also: jekyll#6540 jekyll#6541)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment