Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: upgrade to toml 0.2.0 #6541

Merged
merged 1 commit into from
Nov 11, 2017
Merged

Dependencies: upgrade to toml 0.2.0 #6541

merged 1 commit into from
Nov 11, 2017

Conversation

jekyllbot
Copy link
Contributor

@jekyllbot jekyllbot commented Nov 11, 2017

Fix #6540

Dependencies: upgrade to toml 0.2.0

@ghost
Copy link

ghost commented Nov 11, 2017

0.2.0 or 0.4.0? 😄

@DirtyF DirtyF changed the title Dependencies: upgrade to toml 0.2.0 Dependencies: upgrade to toml 0.4.0 Nov 11, 2017
@DirtyF
Copy link
Member

DirtyF commented Nov 11, 2017

@pup Jekyllbot opened an issue for 0.2.0 but I noticed afterwards that latest version was 0.4.0 😄

@DirtyF
Copy link
Member

DirtyF commented Nov 11, 2017

I should have trusted @jekyllbot: latest gem is 0.2 but latest release of TOML is 0.4

@ghost
Copy link

ghost commented Nov 11, 2017

yeah, it seems to be a pre-release:

image

@DirtyF DirtyF changed the title Dependencies: upgrade to toml 0.4.0 Dependencies: upgrade to toml 0.2.0 Nov 11, 2017
@DirtyF
Copy link
Member

DirtyF commented Nov 11, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 8605f11 into master Nov 11, 2017
@jekyllbot jekyllbot deleted the pull/upgrade-toml branch November 11, 2017 22:35
jekyllbot added a commit that referenced this pull request Nov 11, 2017
@rwxrob
Copy link

rwxrob commented Nov 30, 2017

Sorry if I missed it in the docs but is this thread related to TOML support in Frontmatter? If so WAHOOO, uhuem, and I would love to update the docs. If I had my way I would make TOML supported in everything (after all it is a Tom invention, like Jekyll itself, and ironically is supported in Hugo and no Jekyll, right?)

@parkr
Copy link
Member

parkr commented Nov 30, 2017

Sorry if I missed it in the docs but is this thread related to TOML support in Frontmatter? If so WAHOOO, uhuem, and I would love to update the docs. If I had my way I would make TOML supported in everything (after all it is a Tom invention, like Jekyll itself, and ironically is supported in Hugo and no Jekyll, right?)

Hey @robmuh! TOML is only supported for your configuration file, e.g. _config.toml. TOML has so-so support in Ruby (this gem, really, and I don't believe it's currently maintained), whereas it has excellent support in Go (the language Hugo is written in). That explains the difference in support. In an effort to not confuse folks, I'd be a proponent of just using 1 configuration spec here, and YAML is much better supported in Ruby.

@rwxrob
Copy link

rwxrob commented Nov 30, 2017

Have to say I completely agree with your conclusion. Just wanted to be sure I didn't miss something. I must confess after reading about this Hugo embedded in AWS Lambda approach, which I am not sure is possible with Jekyll, that the scale tipped toward Hugo for me. Thanks for the info.

@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependency constraint to allow for toml v0.2.0
4 participants