Avoid breaking change in latest directory_watcher #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to be a little more pressimistic about the directory_watcher gem, since it's latest version (1.5) breaks jekyll's --auto option. Fixes jekyll#882.
|
What error do you get? Let's update the code in |
|
I don't agree with updating our code to the new version for a couple of
I'd rather restrict us to a known good stable version vs. always being on |
|
How's it broken? |
parkr
added a commit
that referenced
this pull request
Mar 25, 2013
Avoid breaking change in latest directory_watcher
|
Whoops, that was totally the wrong branch. Adding this to master. |
parkr
added a commit
that referenced
this pull request
Mar 25, 2013
parkr
added a commit
that referenced
this pull request
Mar 25, 2013
|
For example of alleged brokenness, see TwP/directory_watcher#22 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be a little more pressimistic about the directory_watcher
gem, since it's latest version (1.5) breaks jekyll's --auto option.
Fixes #882.