New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid breaking change in latest directory_watcher #883

Merged
merged 1 commit into from Mar 25, 2013

Conversation

Projects
None yet
4 participants
@liliakai

liliakai commented Mar 25, 2013

We need to be a little more pressimistic about the directory_watcher
gem, since it's latest version (1.5) breaks jekyll's --auto option.

Fixes #882.

Lilia Markham
Avoid breaking change in latest directory_watcher
We need to be a little more pressimistic about the directory_watcher
gem, since it's latest version (1.5) breaks jekyll's --auto option.

Fixes #882.
@parkr

This comment has been minimized.

Member

parkr commented Mar 25, 2013

What error do you get? Let's update the code in lib/jekyll/commands/build.rb to work with the new version!

@mattr-

This comment has been minimized.

Member

mattr- commented Mar 25, 2013

I don't agree with updating our code to the new version for a couple of
reasons:

  1. The latest version is less than a week old.
  2. It's broken.

I'd rather restrict us to a known good stable version vs. always being on
the latest version when the latest version is obviously broken.

@parkr

This comment has been minimized.

Member

parkr commented Mar 25, 2013

How's it broken?

parkr added a commit that referenced this pull request Mar 25, 2013

Merge pull request #883 from liliakai/0.12.1-release
Avoid breaking change in latest directory_watcher

@parkr parkr merged commit 6cc5341 into jekyll:0.12.1-release Mar 25, 2013

1 check passed

default The Travis build passed
Details
@parkr

This comment has been minimized.

Member

parkr commented Mar 25, 2013

Whoops, that was totally the wrong branch. Adding this to master.

@mattr-

This comment has been minimized.

Member

mattr- commented Mar 25, 2013

For example of alleged brokenness, see TwP/directory_watcher#22

@maul-esel maul-esel referenced this pull request Apr 1, 2013

Closed

Fix auto-generation #899

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.