Fix deprecation warnings from Dart Sass

[ntkme]

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

However, math.div is not supported by sass or sassc used in older version of jekyll-sass-converter. Therefore this PR fixes it in a backward compatible way by replaceing / 2 with * .5, and replacing / 3 with * 33.3333333333 * .01 (a hack for precision in Sass). The css output is exactly same as before.

• Fixes SASS moving to math.div and Minima is using deprecated division #699

@ashmaroli

[ashmaroli]

@ntkme Thanks for submitting a proposal. But why can't we use calc() like the deprecation message suggests?

[ntkme]

We can, but calc is less performant here. The idea of calc is that you can compute based on dynamic values that changes, e.g. calc(100% - 30px), at runtimes. calc(30px / 2) certainly works, but is less optimal since it can be replaced with a constant.

[ashmaroli]

Thanks @ntkme
@jekyylbot: merge +fix

[CarloWood]

Has this been released in a new version yet?

[patch-work]

grep -rai "spacing-unit / 2" /opt/ruby/lib/ruby/gems/3.2.0/gems/minima-2.5.1
/opt/ruby/lib/ruby/gems/3.2.0/gems/minima-2.5.1/_sass/minima.scss://     padding-right: $spacing-unit / 2;
/opt/ruby/lib/ruby/gems/3.2.0/gems/minima-2.5.1/_sass/minima.scss://     padding-left: $spacing-unit / 2;
/opt/ruby/lib/ruby/gems/3.2.0/gems/minima-2.5.1/_sass/minima/_base.scss:  margin-bottom: $spacing-unit / 2;
/opt/ruby/lib/ruby/gems/3.2.0/gems/minima-2.5.1/_sass/minima/_base.scss:  padding-left: $spacing-unit / 2;
/opt/ruby/lib/ruby/gems/3.2.0/gems/minima-2.5.1/_sass/minima/_base.scss:    padding-right: $spacing-unit / 2;
/opt/ruby/lib/ruby/gems/3.2.0/gems/minima-2.5.1/_sass/minima/_base.scss:    padding-left: $spacing-unit / 2;
/opt/ruby/lib/ruby/gems/3.2.0/gems/minima-2.5.1/_sass/minima/_base.scss:    padding: ($spacing-unit / 3) ($spacing-unit / 2);
/opt/ruby/lib/ruby/gems/3.2.0/gems/minima-2.5.1/_sass/minima/_layout.scss:    right: $spacing-unit / 2;
/opt/ruby/lib/ruby/gems/3.2.0/gems/minima-2.5.1/_sass/minima/_layout.scss:  margin-bottom: $spacing-unit / 2;
/opt/ruby/lib/ruby/gems/3.2.0/gems/minima-2.5.1/_sass/minima/_layout.scss:  margin-left: -$spacing-unit / 2;
/opt/ruby/lib/ruby/gems/3.2.0/gems/minima-2.5.1/_sass/minima/_layout.scss:  margin-bottom: $spacing-unit / 2;
/opt/ruby/lib/ruby/gems/3.2.0/gems/minima-2.5.1/_sass/minima/_layout.scss:  padding-left: $spacing-unit / 2;

[agregen]

Has this been released in a new version yet?

The latest release was made over 4 years ago…

[DaveEveritt]

I see here https://github.com/jekyll/minima/tree/master/_sass/minima that "Fix deprecation warnings from Dart Sass" #700 is done, so can someone please explain why - although I have the latest Jekyll and minima in my Gemfile - that I’m still getting these deprecation warnings?