Add platform X supporting in README #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The X is the new brand for Twitter. Signed-off-by: utzcoz <utzcoz@outlook.com>
|
Hi @mattr- , could you help to review this PR? Thanks. |
mattr-
reviewed
May 6, 2024
There was a problem hiding this comment.
The site might be x.com, but if you go there, the title of the page still says Twitter. 🤣
Let's add x to the list of supported icons, since that's a good change, but make some other slight changes to this PR. Much like X itself, I hesitate to go all in with this rebrand.
Co-authored-by: Matt Rogers <mattr-@github.com>
Co-authored-by: Matt Rogers <mattr-@github.com>
|
@mattr- Thanks for your reviewing, PTAL again. |
mattr-
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The X is the new brand for Twitter.