Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Subfolders are being written to in docker (not really a bug) #124

Closed
Uatschitchun opened this issue Sep 24, 2019 · 4 comments
Closed

Subfolders are being written to in docker (not really a bug) #124

Uatschitchun opened this issue Sep 24, 2019 · 4 comments

Comments

@Uatschitchun
Copy link
Contributor

This one is not really a bug, but a security problem!
As because of this:
docker/for-linux#788

Adding a folder with submounts read only like:
-v /media:/media:ro
doesn't make mountpoints underneath /media, like /media/movies, read only, if movies is a mountpoint.
This should be documented here:
https://jellyfin.readthedocs.io/en/latest/administrator-docs/installing/#docker-hub

I was wondering, as jellyfin wrote nfo files and posters to a bind mount that I thought is read only, although it isn't!

I know of many people having their media added to jellyfin like this, who believe, their media is safe this way!

@anthonylavado anthonylavado transferred this issue from jellyfin/jellyfin Sep 27, 2019
Artiume added a commit to Artiume/jellyfin-docs that referenced this issue Nov 29, 2019
Updated docker portions of documentation. Added a note so that a bug can be closed.

jellyfin-archive#124
@ThatNerdyPikachu
Copy link

@anthonylavado Does Jellyfin:

  • ever write to the media files? (I assume not, just wondering :P)
  • write to the folders containing the files on its own, without user configuration of a feature that does that?

Thanks!

@anthonylavado
Copy link
Member

@ThatNerdyPikachu

  1. No
  2. No. As you said, you’d have to enable something, like NFO writing, or keeping images next to the media, etc.

@JustAMan
Copy link
Contributor

  1. Not completely "No" :) there's that dready "Delete" button which an admin can push (and it should not trigger automatically but bugs could happen as we all know)

@dkanada
Copy link
Member

dkanada commented Aug 30, 2020

Looks like a warning was added in the docker section so I'll close this.

@dkanada dkanada closed this as completed Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

5 participants