This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add note about altering the base URL and direct port access.
michaelkrieger
commented
Jun 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing space that was causing a build error
This should resolve #213 Sorry for all the updates- wanted to get the checks/lint perfect and add a but more detail in a few areas. |
joshuaboniface
approved these changes
Jun 24, 2020
z3ntu
reviewed
Jun 24, 2020
Change title to include version Fix a spelling error Clarify HOST_NAME vs DOMAIN_NAME vs HOST_NAME.DOMAIN_NAME to provide a better configuration and combine note about updating it. Minor fix to commented out reference which had an error.
Provide a redirect from http to https on the same port (by providing a non-TLS router on the same port), catching in case someone misses the https when entering the URL (previously provided a 404). Minor improvements to commented sections.
TLS default options were not taking effect in the main configuration vs a provider configuration. Moved to provider configuration. Added TLS sniStrict and curvePreferences (sniStrict disabled would leave TLS1.0 open). Minor configuration tweaks to improve readability and function. Made configuration, by default, not use a Path and made it clearer how to add one Made the jellyfin-insecure redirect point to a no-op service to clean up the dashboard, even though it redirects before it gets to the service.
Sample URL removed as it is not permitted.
Okay- I think I'm done at this point and the configuration is solid and well-tested. More detail (but well commented) was the goal so that it's easy to follow, even if it makes it longer. The configuration meets all security standards, works reliably, etc. Open to any comments, but otherwise it should be good to go. |
Artiume
approved these changes
Jul 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #213
I have added a full guide to using Traefik v2.x with Jellyfin, using as much 'dynamic' configuration of Jellyfin as possible/reasonable.
I tried to make it well commented, including items not directly associated with this configuration, so it is an easy-to-adapt configuration.
I have tested this configuration as working (with the DNS-01 provider) using host networking and with DLNA, but added the necessary blocks for HTTP-01 ACME configuration as well.