Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback progress tracking on external player #195

Closed
Altereno opened this issue Oct 18, 2020 · 13 comments
Closed

Playback progress tracking on external player #195

Altereno opened this issue Oct 18, 2020 · 13 comments
Labels
bug Something isn't working stale

Comments

@Altereno
Copy link

Not sure if this is already a post but when playing a video using the external player (VLC) error pops up after closing the stream. (No valid external player selected. Playback tracking disabled)

@Altereno Altereno added the bug Something isn't working label Oct 18, 2020
@CarlosOlivo
Copy link
Contributor

CarlosOlivo commented Oct 18, 2020

I assume that then you can play multimedia correctly. Could you share the following data?

  • Your Android Versión
  • Application ID / Package Name of VLC
  • Version of VLC Installed

Also can you try with MX Player to see if the same happens?

@Altereno
Copy link
Author

Altereno commented Oct 19, 2020

I assume that then you can play multimedia correctly. Could you share the following data?

  • Your Android Versión
  • Application ID / Package Name of VLC
  • Version of VLC Installed

Also can you try with MX Player to see if the same happens?

Android 10, on the Tab s5e (also happens on my note 9)
Not sure on the package name, can you point me towards where to find it?
VLC version 3.3.1

Worked fine on MX player.

@CarlosOlivo
Copy link
Contributor

Not sure on the package name, can you point me towards where to find it?

See here. I'm not sure if is the same as the mobile versión.

@Altereno
Copy link
Author

Not sure on the package name, can you point me towards where to find it?

See here. I'm not sure if is the same as the mobile versión.

Thanks for the info, not sure if it notifies people when I edit my response so I'll just reply.

org.videolan.vlc

@CarlosOlivo
Copy link
Contributor

Thanks for the info, not sure if it notifies people when I edit my response so I'll just reply.

Yep, they do

org.videolan.vlc

Ok, is the same for mobile & tablet

Can you try this?, download jellyfin-android.zip, extract and try to install jellyfin-android-v0.0.0-dev.1-debug.apk then

  • Login
  • Go to client settings
  • Choose External Player for Video Player Type
  • Choose VLC Player for External player app

See if there is any improvement

Screenshot_20201018-204354_Jellyfin_Debug

@Altereno
Copy link
Author

Thanks for the info, not sure if it notifies people when I edit my response so I'll just reply.

Yep, they do

org.videolan.vlc

Ok, is the same for mobile & tablet

Can you try this?, download jellyfin-android.zip, extract and try to install jellyfin-android-v0.0.0-dev.1-debug.apk then

  • Login
  • Go to client settings
  • Choose External Player for Video Player Type
  • Choose VLC Player for External player app

See if there is any improvement

Screenshot_20201018-204354_Jellyfin_Debug

The option to choose which external player is not there for me. It played the video through VLC though. Still says that playback tracking is disabled.

@CarlosOlivo
Copy link
Contributor

The option to choose which external player is not there for me.

Sorry, wrong link, try this.

@Altereno
Copy link
Author

The option to choose which external player is not there for me.

Sorry, wrong link, try this.
That worked, when do these small get released(on the play store or github)?

@CarlosOlivo
Copy link
Contributor

CarlosOlivo commented Oct 19, 2020

when do these small get released?

No ETA, soon™, maybe...

About why this happens

VLC doesn't always return an activity result unless the correct activity is called, this doesn't always happens, on some devices like mine this works as-is, in others it's required to specify the full activity class VideoPlayerActivity

ExternalPlayerPackage.VLC_PLAYER -> ComponentName(packageName, "$packageName.gui.video.VideoPlayerActivity")

Maybe we need to add a warning somewhere about this and that VLC doesn't support external subtitles either, what do you think @Maxr1998 ?

@Ferk
Copy link

Ferk commented Jan 31, 2021

Maybe this should be discussed with the VLC team at https://code.videolan.org/videolan/vlc-android/-/issues ?

If VLC is behaving in a non-standard way for the video player to play nicely with other android apps on some devices when using it via Intents I'd say it's something that VLC itself could benefit from fixing on their side.

Both for the Playback Tracking and the Subtitles (do the subtitles also work in MX Player?). It would be a pitty to not have proper support for a fully open source external player like VLC. And it has features that both the web and exo players are missing (like modifying the playback speed)

@CarlosOlivo
Copy link
Contributor

Note: libVLC != VLC Android Port

Maybe this should be discussed with the VLC team at https://code.videolan.org/videolan/vlc-android/-/issues ?

Unfortunately the VLC (Android) team decided that the MX Player API is "half insane". But they haven't fixed/improved their API either.

https://trac.videolan.org/vlc/ticket/17133
https://trac.videolan.org/vlc/ticket/14705
https://trac.videolan.org/vlc/ticket/18736

And I don't really like the attitude they take, but you can try discuss with them if you want.

https://code.videolan.org/videolan/vlc-android/-/issues/502

If VLC is behaving in a non-standard way for the video player to play nicely with other android apps on some devices when using it via Intents I'd say it's something that VLC itself could benefit from fixing on their side.

(Un)fortunately in Android there is no such standard, so the implementation depends on each player.

Both for the Playback Tracking and the Subtitles (do the subtitles also work in MX Player?).

Yep

It would be a pitty to not have proper support for a fully open source external player like VLC.

mpv-android is supported.

@Maxr1998 Maxr1998 changed the title Playback tracking? Playback progress tracking on external player May 4, 2021
@jellyfin-bot
Copy link
Contributor

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@Doc-4
Copy link

Doc-4 commented Jul 23, 2024

This problem still exists between current releases of VLC and Jellyfin Android. It also seems to exist between VLC and other 3rd party clients, so it seems to be some kind of VLC
android problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

5 participants