Fix race condition in HomeFragment causing a crash when profile pictu…

…re loads when the view is already destroyed
jellyfin · May 30, 2023 · 570f9ec · 570f9ec
1 parent 5022942
commit 570f9ec
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/app/src/main/java/org/jellyfin/androidtv/ui/home/HomeFragment.kt b/app/src/main/java/org/jellyfin/androidtv/ui/home/HomeFragment.kt
@@ -81,18 +81,24 @@ class HomeFragment : Fragment() {
 			.circleCrop()
 			.into(object : CustomViewTarget<ImageButton, Drawable>(binding.switchUsers) {
 				override fun onLoadFailed(errorDrawable: Drawable?) {
-					binding.switchUsers.imageTintMode = PorterDuff.Mode.SRC_IN
-					binding.switchUsers.setImageDrawable(errorDrawable)
+					if (lifecycle.currentState.isAtLeast(Lifecycle.State.STARTED)) {
+						binding.switchUsers.imageTintMode = PorterDuff.Mode.SRC_IN
+						binding.switchUsers.setImageDrawable(errorDrawable)
+					}
 				}
 
 				override fun onResourceReady(resource: Drawable, transition: Transition<in Drawable>?) {
-					binding.switchUsers.imageTintMode = null
-					binding.switchUsers.setImageDrawable(resource)
+					if (lifecycle.currentState.isAtLeast(Lifecycle.State.STARTED)) {
+						binding.switchUsers.imageTintMode = null
+						binding.switchUsers.setImageDrawable(resource)
+					}
 				}
 
 				override fun onResourceCleared(placeholder: Drawable?) {
-					binding.switchUsers.imageTintMode = PorterDuff.Mode.SRC_IN
-					binding.switchUsers.setImageDrawable(placeholder)
+					if (lifecycle.currentState.isAtLeast(Lifecycle.State.STARTED)) {
+						binding.switchUsers.imageTintMode = PorterDuff.Mode.SRC_IN
+						binding.switchUsers.setImageDrawable(placeholder)
+					}
 				}
 			})
 	}