Rewrite media session code with androidx.media3 #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nielsvanvelzen
force-pushed
the
playback-media3-session
branch
from
e3ed58e
to
e2b220c
Compare
crobibero
approved these changes
May 30, 2023
playback/jellyfin/src/main/kotlin/queue/item/BaseItemDtoUserQueueEntry.kt
Outdated
Show resolved
Hide resolved
nielsvanvelzen
force-pushed
the
playback-media3-session
branch
from
e2b220c
to
018e2af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current media session implementation had a few issues:
In this PR the implementation is rewritten with androidx.media3 and most missing features are added. It works great in my testing (emulator, phone, shield).
Changes
Issues
Part of #1057