Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Feature: Character role based filters (Main, Supporting and Background) #71

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mmshivesh
Copy link
Contributor

@mmshivesh mmshivesh commented May 18, 2024

Draft Pull request adding support for role based filtering of Characters included in the metadata:

Screen Shot 2024-04-29 at 02 37 23 AM@2x

Testing:

  • Rebased on top of the v9 branch, therefore testing not done yet. Build using github action fails here because of a change made from PersonType to "PersonKind" in 89c62c9
  • Older version prior to v8 works fine, and has been tested personally.
  • TODO: Need to verify compatibility with Limit amount of people in metadata search result #66

Opening a Draft PR for the following reasons:

  1. Would it be a good idea to revert the change with naïve VA count filters (Limit amount of people in metadata search result #66) with this smarter system based on character roles? IMO limiting the raw number of results seems like taking a sledgehammer to the problem
  2. UI feedback
  3. Get more pairs of eyes on it for testing, questions about the PersonType -> PersonKind changes

- A bit hacky, uses a Dictionary<string,string> for now
- Defaults to Main characters, and Supporting Characters
- HTML fixes, added missing container tags
- Uses a grouped selection for all the choices
- Adds titles for the sections to make groupings clearer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to limit the number of cast+crew entries
1 participant