-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Arabic subtitles #1387
Comments
Limited support was recently added for a custom CJK font to be used for subtitles. Could you try following the same instructions and see if you can get the arabic fonts working too? Not sure the best place to find fonts. Is this google font the right one?
Edit: This is a known bug #285 so I'm going to change this from a bug to a feature request. |
@cewert First of all, thank you for the quick response! You mentioned CJK fonts, not sure why. Arabic doesn't really fit the CJK category. But I did download the Arabic Noto Sans font and followed your instructions and I do see Arabic letters pop up! However, even though the individual Arabic letters are appearing on-screen, they're being displayed in reversed order, and disconnected. Arabic (And languages that use the Arabic script like Farsi/Persian, Urdu, etc) are right to left languages, and are languages where the letters are supposed to conjoin. I added screenshots below to show the difference. Web: Roku: Lastly, I'm not sure if this is helpful, but I saw some discourse in the bug report you linked about the size of fonts and the limitation of . The most commonly used font for Arabic (far as I know) is Arial, coming in at 1MB, and the lightest font I could find is Omid Light sitting at a pretty 102kb. |
Because I'm pretty ignorant when it comes to langues besides English 😆. I was hoping it would work the same way or at least be close enough to give someone a head start. Based on your feedback I think that might be true still? The codebase assumes the font you are using is CJK but I assume there is a way we can programmatically tell which falback font was given to us by the server. Then it would just be a matter of copy and pasting the custom CJK subtitle parts and modifying them to work for the arabic fonts. Then calling the correct functions after we parse the fallback font from the server. I don't see me working on this issue but if you or someone else would like to give it a try I'll help where I can. Thank you for making a ticket and trying the custom fonts. |
Just a few notes for future devs. Roku does not natively support RTF fonts. So you will need to somehow identify the fallback font is RTF, create a function to reverse the subtitle text prior to display, and adjust the label styles as needed to make it look correctly. |
Software Versions
Describe the bug
Arabic-language srt subtitles do not display properly on Roku, and instead appear as rectangles.
It doesn't work regardless of whether I used subtitles with or without Pop directional formatting characters.
How To Reproduce
Expected behavior
Proper subtitles are displayed. I wish I knew enough to provide more specific details.
Logs
Please let me know if there are any specific logs that would be helpful here.
Screenshots
Connection Information
The text was updated successfully, but these errors were encountered: