Redesign Search page with voice search

[candry7731]

Add Voice search while in folders
Also added a spinner to grid items when loading so user know the app is working
This is to resolve #587

[neilsb]

Is this PR intended to replace the Search Redesign (#568) or should this be looked at after 568 has been merged?

[jimdogx]

This is looking really good!!!!

A couple of things:

• Voice search appears to work everywhere for me except Live TV. If I try to voice search, it doesn't find anything, but the bad part is that you lose focus from the TV guide and can't get it back. Might be worth just seeing if you can remove voice search from the TV guide all together. Because it works great for Movies, TVShows, etc.

• Roku is spitting out a few warnings / errors (even though it appears to work). Might be worth investigating:

*** ERROR: Missing or invalid PHY: '/RokuOS/Keyboards/MiniKeyboardKDF.json'

Warning occurred while setting a field of an RoSGNode
-- Type mismatch occurred when setting the "results" field of a "SearchTask" node
pkg:/components/search/SearchTask.brs(7)

BRIGHTSCRIPT: ERROR: roUrlTransfer.GetToString: Sync-wait interrupted: pkg:/source/api/baserequest.brs(71)

[neilsb]

That's the translation stuff sorted. And voice search seems to be working well.

I'm seeing a problem when selecting search from the options menu on the Home Screen. When the search page opens nothing seems to have focus, so I can't do anything. I'll try and have a look at it shortly.

[jimdogx]

I'm getting a crash when selecting "*" and then "Search" from the Home Screen:

[candry7731]

Jimi, This should be fixed! How do you have the Comment Details in your vscode? [image: image.png]

…

On Wed, Aug 24, 2022 at 6:44 PM Jimi ***@***.***> wrote: I'm getting a crash when selecting "*" and then "Search" from the Home Screen: [image: Screen Shot 2022-08-24 at 5 43 07 PM] <https://user-images.githubusercontent.com/18198517/186543034-5905f0b0-983a-477b-8b03-55e569461978.png> — Reply to this email directly, view it on GitHub <#593 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT6PDRAZH6R34QSFNIAMD3TV22XXDANCNFSM5VS2W6CQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Chris Andry 462 Browning Loop Mandeville LA 70448 504-617-2924

[jimdogx]

Crash is fixed. However, if you click in to any library (Movies, TV Shows, etc), the word "Search" shows up at the top on top of the first thumbnail.

[neilsb]

From the main search screen (accessed via Options menu) search results all look good, and seem to return expected results.

From the results, Movies, TV Shows and Episodes all seem to work as expected also.

However, choosing a Person, Music Album or Music Track item causes the app to crash, as it's trying to display them in the Movie screen, rather than going to appropriate page for the type.

[candry7731]

Formatting

[jimdogx]

Don't know if it matters, but if you speak your password (one character at a time), your password is shown.

Lack of time