-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign Search page with voice search #593
Conversation
Added Key press down to return to TV giude. This seems a more natural way to move from the top details "View channel button" back to the guide.
Update schedule.brs
…to Search-redesign
Added a slew of updates
Is this PR intended to replace the Search Redesign (#568) or should this be looked at after 568 has been merged? |
This is looking really good!!!! A couple of things:
*** ERROR: Missing or invalid PHY: '/RokuOS/Keyboards/MiniKeyboardKDF.json' Warning occurred while setting a field of an RoSGNode BRIGHTSCRIPT: ERROR: roUrlTransfer.GetToString: Sync-wait interrupted: pkg:/source/api/baserequest.brs(71) |
Fix sort names to add back the "_"
Fix TR File to original
Fix naming round 2
That's the translation stuff sorted. And voice search seems to be working well. I'm seeing a problem when selecting search from the options menu on the Home Screen. When the search page opens nothing seems to have focus, so I can't do anything. I'll try and have a look at it shortly. |
Jimi, This should be fixed!
How do you have the Comment Details in your vscode?
[image: image.png]
…On Wed, Aug 24, 2022 at 6:44 PM Jimi ***@***.***> wrote:
I'm getting a crash when selecting "*" and then "Search" from the Home
Screen:
[image: Screen Shot 2022-08-24 at 5 43 07 PM]
<https://user-images.githubusercontent.com/18198517/186543034-5905f0b0-983a-477b-8b03-55e569461978.png>
—
Reply to this email directly, view it on GitHub
<#593 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT6PDRAZH6R34QSFNIAMD3TV22XXDANCNFSM5VS2W6CQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Chris Andry
462 Browning Loop
Mandeville LA 70448
504-617-2924
|
Crash is fixed. However, if you click in to any library (Movies, TV Shows, etc), the word "Search" shows up at the top on top of the first thumbnail. |
From the main search screen (accessed via Options menu) search results all look good, and seem to return expected results. From the results, Movies, TV Shows and Episodes all seem to work as expected also. However, choosing a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know if it matters, but if you speak your password (one character at a time), your password is shown.
Add Voice search while in folders
Also added a spinner to grid items when loading so user know the app is working
This is to resolve #587