-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search redesign #568
Search redesign #568
Conversation
Added Key press down to return to TV giude. This seems a more natural way to move from the top details "View channel button" back to the guide.
Update schedule.brs
…to Search-redesign
Pushed some updates. Make sure to read the "TODO/FIXME" comments I sprinkled throughout 😄 |
Looking good so far! This is a much needed enhancement to the app. A few suggestions:
I wonder if we would be better served showing the results in a single-column vertical scrolling list (like the MarkupList) rather than groups of results by category. This would allow the screen to fully utilize the horizontal space, but at the cost of showing less results on the screen at a time. |
|
@TwitchBronBron Thanks for the suggestions!
|
Added a slew of updates
@TwitchBronBron Posted an update. let me know what you think.
TODO
|
How do I change this from a draft to a normal pr? |
I came across this ticket whole searching for whether voice search support is in progress or planned.
Did support for that make it into this changeset? It would be a massively welcome feature! |
@candry7731 Just changing from using the |
Yes, ill try to get the updated tonight. And also work on the other episode, series pr to kot show for movies. |
Let me know if you guys can use the voice search. |
Yup - voice search works with that change |
THAT'S AWESOME! I'm going to have to get a voice roku player.... lol Now, It looks like there is not logic for "Parental Content" |
This has been updated/Replaced by #593 |
Redesign the search scene
Add observer field to update items based on key press
Changes
Issues