Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search redesign #568

Closed
wants to merge 22 commits into from
Closed

Conversation

candry7731
Copy link
Contributor

Redesign the search scene
Add observer field to update items based on key press

Changes

  1. Added Mini Keyboard
  2. Moved to the left most side

Issues

  1. Need to add logic for observer field in the searchbox.brs
  2. Add searchrow layout or grid layout to update itmes when keys are pressed

@jimdogx
Copy link
Contributor

jimdogx commented May 3, 2022

Pushed some updates. Make sure to read the "TODO/FIXME" comments I sprinkled throughout 😄

@TwitchBronBron
Copy link
Contributor

TwitchBronBron commented May 4, 2022

Looking good so far! This is a much needed enhancement to the app. A few suggestions:

  1. don't focus the first search result after typing. The focus should stay on the keyboard all the time, unless the user manually leaves the text box by pressing right enough times.

    jellyfin-search.mp4
  2. Don't show the loading spinner on screen load. We should only be showing it when actually loading. Perhaps show some text there instead, like "Start typing to instantly see search results" or even just "No results found".

  3. For episodes, I don't know what show they belong to.
    image

I wonder if we would be better served showing the results in a single-column vertical scrolling list (like the MarkupList) rather than groups of results by category. This would allow the screen to fully utilize the horizontal space, but at the cost of showing less results on the screen at a time.

@candry7731
Copy link
Contributor Author

Looking good so far! This is a much needed enhancement to the app. A few suggestions:

  1. don't focus the first search result after typing. The focus should stay on the keyboard all the time, unless the user manually leaves the text box by pressing right enough times.

    jellyfin-search.mp4
    
  2. Don't show the loading spinner on screen load. We should only be showing it when actually loading. Perhaps show some text there instead, like "Start typing to instantly see search results" or even just "No results found".

  3. For episodes, I don't know what show they belong to.
    image

I wonder if we would be better served showing the results in a single-column vertical scrolling list (like the MarkupList) rather than groups of results by category. This would allow the screen to fully utilize the horizontal space, but at the cost of showing less results on the screen at a time.

@candry7731 candry7731 closed this May 4, 2022
@candry7731 candry7731 reopened this May 4, 2022
@candry7731
Copy link
Contributor Author

candry7731 commented May 4, 2022

@TwitchBronBron Thanks for the suggestions!

  1. Focus will stay on the keyboard, trying to work out the best logic for that

  2. I like the "no results found" text...

  3. maybe adding a show title above the episode name or adding the show name above the image and the episode name below the image?
    The web app show the show name above the episode name
    image

  4. I will also try to add voice search option to the keyboard, Do you have a voice remote?

@candry7731
Copy link
Contributor Author

@TwitchBronBron Posted an update. let me know what you think.

  1. Added Series name above the episode poster
  2. Fixed focus to stay on keyboard until user presses left to focus on search results
  3. Updated search url to search the "Search/Hints" api
  4. Updated to search function to search the entire letter string instead of waiting until it times out to update the letter string

TODO

  1. Add animation to the keyboard to slide on and off screen when focus changes between keyboard and search results
  2. update search url to search each "type" and have no limits as you are searching the entire search term and that should auto filter/limit the results

@candry7731
Copy link
Contributor Author

How do I change this from a draft to a normal pr?

@jimdogx
Copy link
Contributor

jimdogx commented May 6, 2022

image

@candry7731 candry7731 marked this pull request as ready for review May 6, 2022 21:28
@tremby
Copy link

tremby commented May 7, 2022

I came across this ticket whole searching for whether voice search support is in progress or planned.

I will also try to add voice search option to the keyboard, Do you have a voice remote?

Did support for that make it into this changeset? It would be a massively welcome feature!

@neilsb
Copy link
Member

neilsb commented May 9, 2022

@candry7731 Just changing from using the MiniKeyboard to the DynamicMiniKeyboard component should give you the voice search automatically. It has an inbuild textbox, so looks like you may have to make some other small changes, but it should be fairly straightforward.

@candry7731
Copy link
Contributor Author

Yes, ill try to get the updated tonight. And also work on the other episode, series pr to kot show for movies.

@candry7731
Copy link
Contributor Author

Let me know if you guys can use the voice search.

@neilsb
Copy link
Member

neilsb commented May 10, 2022

Let me know if you guys can use the voice search.

Yup - voice search works with that change

@candry7731
Copy link
Contributor Author

Let me know if you guys can use the voice search.

Yup - voice search works with that change

THAT'S AWESOME! I'm going to have to get a voice roku player.... lol

Now, It looks like there is not logic for "Parental Content"

@candry7731
Copy link
Contributor Author

This has been updated/Replaced by #593

@candry7731 candry7731 closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants