feat,fix,refactor&perf: offline navigation, full item reactivity, simplifications and bug fixes #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This composable reactively runs requests and returns reactive BaseItemDto copies Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
With the new composables the store is indeed obsolete Also remove audios from the resume section Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
…nts to api composables Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Rely only on axios interceptor to report the loading state Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Use the new composable in LikeButton Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
* Ensure reactivity by not destructuring itemId in most places * Removed placeholder for Vuetify skeletons, we're not going to use them anymore with the refactors Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
* Endless loading was fixed by initializing the loading ref to false. resolveAndAdd has full control now. * Requests loops were happening because the watcher could fire. Given the passed objects are getters, it was difficult for it to determine if the args really changed. Now, we map toValue and check for equality Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
This was the main thing that lead to ReferenceErrors and circular dependencies. Wasn't refactored before to at least get the client working in production (although with quite a lot of reference errors) Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
When there's no connection, the request will be saved so it gets executed as soon as the connection to the server is recovered Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Allows for fine-grained control over the loading state. Merge skipCache with it. Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
* Remove the animation, showing only the Vuetify's background colors for each color scheme. * Move all the splashscreen logic to App.vue, so we can hide the splashscreen only when suspense has finished resolving everything Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Do a single loop instead of 2 Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
…t in progress Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
We've never been using Suspense to blcok navigation properly (which wasn't so relevant, since we didn't have many long promises like we have now) We were wrongly swapping the key prop in the div, which effectively killed the inner suspense, not taking into account the async dependency tree Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
…ary page Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
This was
linked to
issues
Jan 8, 2024
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
ferferga
force-pushed
the
feat-offline-navigation
branch
3 times, most recently
from
2a043a8
to
bcae7f7
Compare
This is probably better than having a giant collection with another level of nesting Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
ferferga
force-pushed
the
feat-offline-navigation
branch
2 times, most recently
from
a708c19
to
98df2d6
Compare
|
Was going to test #2129, and noticed when you attempt a login with incorrect password it shows the error as expected, however does not reset the "loading" state. This works as expected on nightly (aside from the infinite loading bar). |
|
@ferferga Thank you for taking the time to write all this up! Great explanation and it makes total sense. ;) |
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
ferferga
force-pushed
the
feat-offline-navigation
branch
2 times, most recently
from
9e23eeb
to
c68d0f1
Compare
|
@EffakT Good catch! Try now please, both issues should be fixed |
ferferga
force-pushed
the
feat-offline-navigation
branch
from
c68d0f1
to
3b4e9d2
Compare
|
@ferferga Not sure if its related to the last change, it doesn't seem to be loading the video information (video/audio/subtitles) on first load of a episode page. Though, can confirm both the login and play status issues are sorted. |
* Do a first pass on playback's manager watchers. The lack of sync was causing playback reporting to miss updates * Set post as flush timer for stores cleanup Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
* Also removed unnecessary setting from VSCode settings.json (reported by Volar) Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
ferferga
force-pushed
the
feat-offline-navigation
branch
from
3b4e9d2
to
6c9fdf4
Compare
|
Cloudflare Pages deployment
|
Open
Open
|
@EffakT I fixed it as well, not caused by this PR but no hassle to include it either. Shipping now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been out a lot due to uni, but I'm not with empty hands either :):
Fixes #2194 #2129 #1921, possibly fixes #1803 #1717 #801 #762
Improves #2028 (major leak was fixed, but there are still some on full music's player swiper and the draggable queue)
Development improvements
Fully new data fetching. Created the new
useApianduseBaseItemcomposables, deprecateuserLibrariesanditemsStore, createdapiStore. Both composables are fully documented in the codebase, but here's a brief explanation:undefinedFix Suspense not really blocking navigation before resolve.
Fix development build not working
Fix the memory leak (root source was the items store, which we couldn't properly fix back at the time). The most memory and CPU intensive parts of the application are still the library pages, but even while on them, the GC fires with light scrolling, so it looks like that all our data structures are easily GCeable.
User facing improvements
Some videos:
2024-01-08.18-56-23.mp4
2024-01-08.18-57-55.mp4
2024-01-08.19-01-52.mp4