Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(global.scss): fix line height truncating a lot of letters #467

Closed
wants to merge 1 commit into from
Closed

fix(global.scss): fix line height truncating a lot of letters #467

wants to merge 1 commit into from

Conversation

ThibaultNocchi
Copy link
Member

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ferferga
Copy link
Member

ferferga commented Jan 1, 2021

@ThibaultNocchi Any reason why this is still a WIP?

@ThibaultNocchi
Copy link
Member Author

@ferferga yep, as both you and @MrTimscampi don't have the problem I have, I don't think it should be merged. Either it's not a common problem and it's not a really good idea to blanket erase all the line-height rules of Vuetify, or it's a common one and maybe there is / will be a better solution.

@heyhippari
Copy link
Contributor

Closing this for now, since it seems to be a user-specific issue. We can always re-open it if more people come out with the same problem.

@heyhippari heyhippari closed this Jan 5, 2021
@ThibaultNocchi
Copy link
Member Author

Do you know if I can delete the branch for now? Or should it stay to keep the commits for the PR?

@heyhippari
Copy link
Contributor

If you want to keep this PR, you should leave the branch. Otherwise, you can safely delete it.

The changes are so small that we could pretty easily make a new PR if need be, so it's up to you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants