fix(tv show tabs): add sorting to vuex store to fix season ordering

[camc314]

Potentially fixes #479

After adding the array of episodes of each season. Sort by parentIndexNumber

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codecov-io]

Codecov Report

Merging #480 (4946183) into master (b3cb5d8) will increase coverage by 0.49%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
+ Coverage   11.76%   12.25%   +0.49%     
==========================================
  Files         133      133              
  Lines        3451     3451              
  Branches      525      525              
==========================================
+ Hits          406      423      +17     
+ Misses       3024     3005      -19     
- Partials       21       23       +2     

Impacted Files	Coverage Δ
components/Item/SeasonTabs.vue	0.00% <0.00%> (ø)
store/tvShows.ts	37.77% <60.00%> (+37.77%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3cb5d8...4946183. Read the comment docs.

[heyhippari]

Analyzing this a bit, this seems more like a logic issue in how the data is structured and assigned than a sorting issue.

We're assigning episodes to an array, by combining the existing contents of the array with the new one. However, nothing guarantees that we are going to receive the seasons in the proper order or that said seasons would contain anything, or even return at all.

I think the proper fix for this would be to rework the structure to be like so:

const TvShowsState = {
  '494947c860b2d2abaa645bffb9fde158': {
    'seasons': {
      0: {
        'information': BaseItemDto // The season's info
        'episodes': BaseItemDto[] // An array of all the episodes
      }
    }
  }
}

This way, we can set the info by key instead of by index, which allows us to go from 0 to 4 back to 2, as items come in. It also sets us up for adding more info to this store at a later date (Like storing the series' info directly in the store).

Edit: though another, maybe more valid way to do this would be to split episodes and seasons into two stores, then use getters to fetch what we need and collate data in the components instead.
This has the advantage of keeping the stores as flat as possible and allowing us to limit the amount of duplicate data, thereby making the subsequent updates we'll need to do through the websocket messages easier.

[heyhippari]

Should've probably marked my previous comment as a request for change, as the current way of doing things won't solve the core issue we're having.

[camc314]

Finally updated to use an object. Should be working now

state: {
  'seriesId': {
    seasons: [] // Array of seasons (S01, S02...)
    seasonEpisodes: {
      'season-id': [S01E01, S01E02],
      'season-id': [S02E01, S02E02]
    }
  }
}

[ThibaultNocchi]

You can also simplify your Vue.set calls by just editing a sub-prop such as there:

jellyfin-vue/store/displayPreferences.ts

Line 96 in e70915b

Vue.set(state.CustomPrefs, key, defaultCustomPrefs[key]);

[camc314]

You can also simplify your Vue.set calls by just editing a sub-prop such as there:

jellyfin-vue/store/displayPreferences.ts

Line 96 in e70915b

Vue.set(state.CustomPrefs, key, defaultCustomPrefs[key]);

The only issue is that state[itemId] may not be defined yet. By setting the whole state, we create the property on state if it is not already defined

[ThibaultNocchi]

Yeah that seems fair then

[ThibaultNocchi]

@camc314 Also did you see the small comments I left? :)

[camc314]

@camc314 Also did you see the small comments I left? :)

Yep, I'll address them in the next few hours 👍

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

No Coverage information
0.0% Duplication

Stale