fix(card hover): fix instantly playing items when clicking in center on touch devices #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #623 +/- ##
=======================================
Coverage 10.25% 10.25%
=======================================
Files 105 105
Lines 2916 2916
Branches 444 444
=======================================
Hits 299 299
Misses 2601 2601
Partials 16 16
Continue to review full report at Codecov.
|
…on touch devices Previously, if you were to click on the center of a card on a touch device (mobile not supported) it would instantly begin playback since you clicked where the "Play" icon would have been. This commit sets display to none if hover is not supported
|
Kudos, SonarCloud Quality Gate passed!
|
|
This is fixed in a (imo) nicer way by #616, by removing the overlay entirely if we're on a mobile device. |
|
Ah I didn't see that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you were to click on the center of a card on a touch device (mobile not supported) it
would instantly begin playback since you clicked where the "Play" icon would have been. This commit
sets display to none if hover is not supported