Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(browser): add browser detection plugin #70

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Conversation

heyhippari
Copy link
Contributor

@heyhippari heyhippari commented Sep 10, 2020

Adds a plugin that injects a class instance into the context with utilities to detect the current platform.

Supports:

  • Firefox
  • Chrome
  • Edge
  • Safari
  • WebOS
  • Tizen

Has utilities for:

  • Getting the Safari version
  • Guessing if we're on mobile
  • Guessing if we're on a Smart TV

Part of #60

@heyhippari heyhippari mentioned this pull request Sep 10, 2020
3 tasks
plugins/browserDetection.ts Show resolved Hide resolved
plugins/browserDetection.ts Outdated Show resolved Hide resolved
@heyhippari
Copy link
Contributor Author

I added some more utilities to detect Tizen 5 and all the WebOS versions, since I'm starting to need them while working on the playback profile generation.

@camc314
Copy link
Contributor

camc314 commented Sep 10, 2020

I added some more utilities to detect Tizen 5 and all the WebOS versions, since I'm starting to need them while working on the playback profile generation.

Sounds good. I'll leave you to merge incase you need to add any further browser detection

@heyhippari heyhippari merged commit a0c0766 into master Sep 11, 2020
@heyhippari heyhippari deleted the feat/browser branch September 11, 2020 11:38
@heyhippari heyhippari added this to the Preview Release 1 milestone Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants