Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add playback profile detection #71

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Add playback profile detection #71

merged 2 commits into from
Sep 14, 2020
+1,034 −1

Conversation

heyhippari
Copy link
Contributor

@heyhippari heyhippari commented Sep 10, 2020 •
edited
Loading

Adds full playback profile generation. Should be identical to jf-web in the result, with some exceptions for dropped platforms.

Part of #60

@heyhippari heyhippari mentioned this pull request Sep 10, 2020
Closed
3 tasks
@heyhippari heyhippari force-pushed the feat/playback-profile branch 2 times, most recently from 24dfccd to 210e10c Compare September 11, 2020 11:34
@heyhippari heyhippari marked this pull request as ready for review September 11, 2020 11:34
@heyhippari heyhippari requested a review from a team September 11, 2020 11:56
camc314
camc314 reviewed Sep 11, 2020
View reviewed changes
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a change to look through this thoroughly, but looks good so far. We probably want to add the few missing JSDOC @returns declaration

plugins/playbackProfile.ts Show resolved Hide resolved
utils/webmAudioFormats.ts Outdated Show resolved Hide resolved
plugins/playbackProfile.ts Show resolved Hide resolved
utils/transcodingFormats.ts Outdated Show resolved Hide resolved
camc314
camc314 reviewed Sep 12, 2020
View reviewed changes
utils/audioFormats.ts Show resolved Hide resolved
utils/audioFormats.ts Show resolved Hide resolved
plugins/playbackProfile.ts Show resolved Hide resolved
camc314
camc314 approved these changes Sep 12, 2020
View reviewed changes
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me I won't merge it yet, and leave it to see if anyone else from @jellyfin/web want's to review.

@camc314 camc314 merged commit fcc8782 into master Sep 14, 2020
@camc314 camc314 deleted the feat/playback-profile branch September 14, 2020 19:12
@heyhippari heyhippari added this to the Preview Release 1 milestone Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Preview Release 1
Development

Successfully merging this pull request may close these issues.
2 participants
@heyhippari @camc314