Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(card): fix no images appearing on some cards on home screen #711

Merged
merged 1 commit into from
Feb 11, 2021
Merged

fix(card): fix no images appearing on some cards on home screen #711

merged 1 commit into from
Feb 11, 2021

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Feb 11, 2021

Fixes #708

@sonarcloud
Copy link

sonarcloud bot commented Feb 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ferferga
Copy link
Member

How are CollectionFolder, Folder and UserView types handled now?

@camc314
Copy link
Contributor Author

camc314 commented Feb 11, 2021 •
edited
Loading

I'm going to double check. But I think It's unchanged

Library's primary image is a thumb shape so there's no change. @ferferga

@camc314 camc314 mentioned this pull request Feb 11, 2021
Closed
16 tasks
@ferferga ferferga merged commit 1523570 into master Feb 11, 2021
@ferferga ferferga deleted the fix/img2 branch February 11, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferferga ferferga ferferga approved these changes

@ThibaultNocchi ThibaultNocchi Awaiting requested review from ThibaultNocchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Next up covers aren't loaded
3 participants
@camc314 @ferferga @ThibaultNocchi