Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SyncPlay, don't use bad ApiClient #2183

Merged
merged 1 commit into from
Dec 7, 2020
Merged

SyncPlay, don't use bad ApiClient #2183

merged 1 commit into from
Dec 7, 2020

Conversation

dmitrylyzo
Copy link
Contributor

I think this is more a hack than a fix.

In multiserver app (Tizen), SyncPlay starts too early and undefined apiClient is passed to it.
SyncPlay probably requires some changes to support server switching (cc @OancaAndrei).

Changes

  • Check apiClient before use.
  • Watch for creation of ApiClient.

Issues
In multiserver app, undefined apiClient is passed to SyncPlay.

How to check multiserver with DevServer

  • Enable mutliserver
  • yarn serve
  • Open DevServer in browser.
  • Clear localStorage for DevServer.
  • Refresh.
  • You should see Select Server page.

@sonarcloud
Copy link

sonarcloud bot commented Dec 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

@OancaAndrei
Copy link
Contributor

OancaAndrei commented Dec 5, 2020 •
edited
Loading

Nice catch, I've never actually tested it with multiserver enabled. I'll need to have a look and reset things where due when setting a new ApiClient.

@thornbill thornbill added the stable backport Backport into the next stable release label Dec 5, 2020
@dkanada dkanada merged commit 9815c64 into jellyfin:master Dec 7, 2020
joshuaboniface pushed a commit that referenced this pull request Dec 14, 2020
@dkanada @joshuaboniface
Merge pull request #2183 from dmitrylyzo/fix-multiserver-syncplay
972ecc4 
SyncPlay, don't use bad ApiClient

(cherry picked from commit 9815c64)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Dec 14, 2020
@dmitrylyzo dmitrylyzo deleted the fix-multiserver-syncplay branch February 20, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

@dkanada dkanada dkanada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dmitrylyzo @OancaAndrei @thornbill @dkanada @joshuaboniface