Fix possible HLSError (BufferFullError) on Firefox #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
thornbill
approved these changes
Dec 14, 2020
heyhippari
approved these changes
Dec 14, 2020
joshuaboniface
pushed a commit
that referenced
this pull request
Dec 31, 2020
Fix possible HLSError (BufferFullError) on Firefox (cherry picked from commit ebb4b05) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
njsmith
added a commit
to njsmith/jellyfin-web
that referenced
this pull request
Aug 10, 2021
The hls.js maxBufferLength parameter sets the minimum amount of video that hls.js will try to buffer. We used to have this set to 30 seconds, but this caused problems with high-bitrate videos trying to buffer too much data and making Chrome/Firefox cranky, so maxBufferLength was reduced in jellyfin#2148 and jellyfin#2224. However, those PRs *also* reduced maxMaxBufferLength to 6 seconds, which doesn't make sense -- basically this is telling hls.js that it must *never* buffer more than 6 seconds at a time, even if there's plenty of memory and it wouldn't make the browser cranky at all. And obviously such a tiny buffer makes it very easy for small network glitches to cause user-visible playback problems. So this PR removes the maxMaxBufferLength configuration entirely, accepting hls.js's default (which is currently 600 seconds). Fixes jellyfin#2856
viggy96
pushed a commit
to viggy96/jellyfin-web
that referenced
this pull request
Aug 24, 2021
The hls.js maxBufferLength parameter sets the minimum amount of video that hls.js will try to buffer. We used to have this set to 30 seconds, but this caused problems with high-bitrate videos trying to buffer too much data and making Chrome/Firefox cranky, so maxBufferLength was reduced in jellyfin#2148 and jellyfin#2224. However, those PRs *also* reduced maxMaxBufferLength to 6 seconds, which doesn't make sense -- basically this is telling hls.js that it must *never* buffer more than 6 seconds at a time, even if there's plenty of memory and it wouldn't make the browser cranky at all. And obviously such a tiny buffer makes it very easy for small network glitches to cause user-visible playback problems. So this PR removes the maxMaxBufferLength configuration entirely, accepting hls.js's default (which is currently 600 seconds). Fixes jellyfin#2856
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Limit the
BufferLengthto 6s on Firefox too. See #2148.Issues
Fixes #2223.