Fix layout of plugin cards #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
force-pushed
the
fix-plugin-cards
branch
from
1a4c6c2
to
ae9f1a0
Compare
|
SonarCloud Quality Gate failed.
|
crobibero
approved these changes
Dec 16, 2020
nielsvanvelzen
approved these changes
Dec 16, 2020
heyhippari
approved these changes
Dec 16, 2020
joshuaboniface
pushed a commit
that referenced
this pull request
Dec 31, 2020
Fix layout of plugin cards (cherry picked from commit be57362) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the icons in plugin cards not being vertically aligned. This was due to the
cardContentstyling overriding thecardImageContainerstyling. Typically thecardContentclass is applied to a different element not the same element, so this rule forcesdisplay: flexin the few cases where both are applied on the same element.Issues
N/A