Sort items by premiere date on the details page #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Maxr1998
approved these changes
Dec 25, 2020
thornbill
approved these changes
Dec 25, 2020
nielsvanvelzen
approved these changes
Dec 25, 2020
camc314
approved these changes
Dec 25, 2020
joshuaboniface
pushed a commit
that referenced
this pull request
Dec 31, 2020
Sort items by premiere date on the details page (cherry picked from commit 58aa865) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently, the details page sorts items by production year. This can cause weirdness when, for example, two albums are released the same year, in which case they may sort in the wrong order.
This adds PremiereDate as the first sorting field for everything filtered by dates on the details page, with a fallback to ProductionYear, then SortName to keep the current behavior as a fallback in case there is no PremiereDate.
Issues