Add missing Languages to Web #2280
Conversation
There was a problem hiding this comment.
New languages also need added here: https://github.com/jellyfin/jellyfin-web/blob/master/src/scripts/site.js#L71
New date locales need to be mapped appropriately here: https://github.com/jellyfin/jellyfin-web/blob/master/src/scripts/dfnshelper.js#L6
|
for locales, would i use 'bn_bd': bn, or use a dash? |
|
esperato has no locale, ignore it or give it something else? |
|
It looks like bn and eo should work https://github.com/date-fns/date-fns/tree/master/src/locale |
| <option value="be-BY">Belarusian (Belarus)</option> | ||
| <option value="bg-BG">Bulgarian (Bulgaria)</option> | ||
| <option value="be-BY">Belarusian</option> | ||
| <option value="bn_BD">Bengali (Bangladesh)</option> |
There was a problem hiding this comment.
Some of these don't exist as date-fns locales. Should they all be?
Also some of them don't match the name of the locales in dfnshelper. There seems like there may be another place where they get normalized as some of the existing locales also don't match, but I'm not familiar with where or how that happens.
There was a problem hiding this comment.
I was hoping you knew lol. I noticed it was being parsed differently so I wasn't sure how to verify my work.
There was a problem hiding this comment.
Our locales are here: https://github.com/jellyfin/jellyfin-web/blob/master/src/scripts/site.js#L71
The strings in dfnshelper matches those locales using our code as a key with the date fns locale object as value
There was a problem hiding this comment.
mr wasnt a locale listed so i removed it, it should be good after that.
thornbill
dismissed
their stale review
The changes have been addressed. Added a comment with some additional questions.
|
SonarCloud Quality Gate failed.
|
(cherry picked from commit b7eeebd) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Changes
Issues
#2267