fix image alignment on plugin cards #2343
Conversation
|
We can always tweak the default color generation method, but the cards themselves need some kind of placeholder to differentiate the image section from the footers. |
|
The addition of the background colors looks pretty terrible imo. The color is shown behind transparent user images. A large number of cards on a page becomes very overwhelming. The colors change if you leave a page and return or reload the page. And it seems they aren't applied to all cards (see the tuner cards).
|
|
The intent was definitely to style them all the same, tuner cards were only unaffected because I didn't know they existed. I can add them as well if you'd like. I personally love all the other images you perceived as negative. How would it sound to reduce the number of colors in the pallette or make them more similar? I will admit the brighest shade of blue is a bit too much for my taste. Regarding the transparent images, I can remove the background when an image is present to keep the old behavior. If we're putting this much effort into the style changes I'd still like to backport them for 10.7.1 as a UX improvement, which I consider valid for backports. |
|
Don't we already use these sort of range of colors for item cards, Personally, I don't mind what we decided to do, but it wouldnt it make sense to use the same sort of colors everywhere? |
|
We did indeed, and it would indeed, which was the idea behind this pull request. However, I'm not against tweaking the pallette used at the same time. Like I said, the brighter shades are definitely a bit in your face. |
|
We do use these colors for other cards also but only ever as placeholders when an image is missing. I don’t like the choice of colors for those cases either but it’s much more aggressive having a full page of these all over the dashboard. |
|
We shouldn't assume that every user has metadata good enough to scrape images for a majority of their media, or even that every user wants to enable images globally. For example, I use images for posters and thumbnails but prefer to leave genres and people untouched. I don't even enable metadata providers for most of my libraries. We should just design the placeholders with the assumption that they should look good even when no images are present. Like I said, feel free to make suggestions about what colors (or color) we should use, we can always change the default theme to make them less aggresive when it's a full page of placeholders. Also, I'd like to point out that even though it's a stretch to call the device images placeholders, both the active devices and plugin cards are definitely placeholders in the proper sense, so they should be styled as such. Devices and tuners are the only two I can think of that don't really have actual images to prioritize, but I styled them to match literally every other card that exists in the client. |
|
Kudos, SonarCloud Quality Gate passed!
|
fix image alignment on plugin cards (cherry picked from commit 536797a) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
No description provided.