Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: message appearing after adding repositories #2375

Merged
merged 1 commit into from
Feb 4, 2021
Merged

fix: message appearing after adding repositories #2375

merged 1 commit into from
Feb 4, 2021

Conversation

ferferga
Copy link
Member

@ferferga ferferga commented Feb 3, 2021

Fixes the "No repository" message appearing after adding repositories:

Steps to reproduce:

  • Delete all the repositories. "No repository" message will appear.
  • Add a new repository
  • New repository will be added to the list, but the message will still be there

Expected behaviour:

Message doesn't appear as soon as the new repository is added

@ferferga ferferga requested a review from dkanada February 3, 2021 15:19
@ferferga ferferga added the stable backport Backport into the next stable release label Feb 3, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ferferga ferferga requested a review from a team February 4, 2021 13:12
@dkanada dkanada merged commit bd297ef into master Feb 4, 2021
@dkanada dkanada deleted the fix-no-repository-message branch February 4, 2021 14:25
joshuaboniface pushed a commit that referenced this pull request Feb 21, 2021
@dkanada @joshuaboniface
Merge pull request #2375 from jellyfin/fix-no-repository-message
9304215 
fix: message appearing after adding repositories
(cherry picked from commit bd297ef)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

@dkanada dkanada dkanada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ferferga @nielsvanvelzen @dkanada @joshuaboniface